refactor: Return consistent empty slice from .All() methods #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clients `.All()` & `.AllWithOpts()` methods returned an inconsistent slice value when no resources were found. Some clients returned a `nil` slice while others returned an empty slice with 0 entries. This makes sure that all methods return empty slices except if an actual error occured.
apricote
added
the
backport release-1.x
jooola
approved these changes
Aug 8, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
The clients `.All()` & `.AllWithOpts()` methods returned an inconsistent slice value when no resources were found. Some clients returned a `nil` slice while others returned an empty slice with 0 entries. This makes sure that all methods return empty slices except if an actual error occured. (cherry picked from commit 88f5871)
apricote
added a commit
that referenced
this pull request
Aug 8, 2023
) The clients `.All()` & `.AllWithOpts()` methods returned an inconsistent slice value when no resources were found. Some clients returned a `nil` slice while others returned an empty slice with 0 entries. This makes sure that all methods return empty slices except if an actual error occured. (cherry picked from commit 88f5871) Co-authored-by: Julian Tölle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clients
.All()&.AllWithOpts()methods returned an inconsistent slice value when no resources were found. Some clients returned anilslice while others returned an empty slice with 0 entries.This makes sure that all methods return empty slices except if an actual error occured.